feat: introduce maxEntrySize, for enabling error message truncation #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
requested review from
JustinBeckwith,
callmehiphop,
alexander-fenster and
DominicKramer
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
==========================================
- Coverage 97.21% 96.84% -0.37%
==========================================
Files 10 10
Lines 431 444 +13
Branches 55 60 +5
==========================================
+ Hits 419 430 +11
- Partials 12 14 +2
Continue to review full report at Codecov.
|
JustinBeckwith
suggested changes
Oct 15, 2019
alexander-fenster
approved these changes
Oct 15, 2019
DominicKramer
approved these changes
Oct 16, 2019
|
What are the units of maxEntrySize? |
|
@xtellurian I assume you sorted this out but for anyone else, it's bytes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduces the configuration setting
maxEntrySizewhich, if set, will make a best effort to truncate text log entries, such that they don't result in an exception, see:https://cloud.google.com/logging/quotas
Note: as follow up, we should set this option to
256,000on logging-bunyan, and logging-winston.fixes #427