Skip to content

Commit

Permalink
updated FQDN's to googleapis.com with a trailing dot (#2214)
Browse files Browse the repository at this point in the history
  • Loading branch information
ericuldall authored and callmehiphop committed Apr 14, 2017
1 parent 3498972 commit 70d10e1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function PubSub(options) {
return new PubSub(options);
}

this.defaultBaseUrl_ = 'pubsub.googleapis.com';
this.defaultBaseUrl_ = 'pubsub.googleapis.com.';
this.determineBaseUrl_();

var config = {
Expand Down
4 changes: 2 additions & 2 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ describe('PubSub', function() {

var calledWith = pubsub.calledWith_[0];

var baseUrl = 'pubsub.googleapis.com';
var baseUrl = 'pubsub.googleapis.com.';
assert.strictEqual(calledWith.baseUrl, baseUrl);
assert.strictEqual(calledWith.service, 'pubsub');
assert.strictEqual(calledWith.apiVersion, 'v1');
Expand All @@ -161,7 +161,7 @@ describe('PubSub', function() {
});

it('should set the defaultBaseUrl_', function() {
assert.strictEqual(pubsub.defaultBaseUrl_, 'pubsub.googleapis.com');
assert.strictEqual(pubsub.defaultBaseUrl_, 'pubsub.googleapis.com.');
});

it('should use the PUBSUB_EMULATOR_HOST env var', function() {
Expand Down

0 comments on commit 70d10e1

Please sign in to comment.