fix: preserve default values in x-goog-request-params header (#1622)

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 474338479 Source-Link: googleapis/googleapis@d5d35e0 Source-Link: googleapis/googleapis-gen@efcd3f9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9
googleapis · Sep 14, 2022 · 76c0ab5 · 76c0ab5
1 parent 907b623
commit 76c0ab5
Show file tree

Hide file tree

Showing 6 changed files with 1,609 additions and 1,504 deletions.
diff --git a/src/v1/publisher_client.ts b/src/v1/publisher_client.ts
@@ -490,7 +490,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        name: request.name || '',
+        name: request.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.createTopic(request, options, callback);
@@ -578,7 +578,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        'topic.name': request.topic!.name || '',
+        'topic.name': request.topic!.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.updateTopic(request, options, callback);
@@ -663,7 +663,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        topic: request.topic || '',
+        topic: request.topic ?? '',
       });
     this.initialize();
     return this.innerApiCalls.publish(request, options, callback);
@@ -745,7 +745,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        topic: request.topic || '',
+        topic: request.topic ?? '',
       });
     this.initialize();
     return this.innerApiCalls.getTopic(request, options, callback);
@@ -831,7 +831,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        topic: request.topic || '',
+        topic: request.topic ?? '',
       });
     this.initialize();
     return this.innerApiCalls.deleteTopic(request, options, callback);
@@ -916,7 +916,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        subscription: request.subscription || '',
+        subscription: request.subscription ?? '',
       });
     this.initialize();
     return this.innerApiCalls.detachSubscription(request, options, callback);
@@ -1010,7 +1010,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project: request.project || '',
+        project: request.project ?? '',
       });
     this.initialize();
     return this.innerApiCalls.listTopics(request, options, callback);
@@ -1051,7 +1051,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project: request.project || '',
+        project: request.project ?? '',
       });
     const defaultCallSettings = this._defaults['listTopics'];
     const callSettings = defaultCallSettings.merge(options);
@@ -1099,7 +1099,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project: request.project || '',
+        project: request.project ?? '',
       });
     const defaultCallSettings = this._defaults['listTopics'];
     const callSettings = defaultCallSettings.merge(options);
@@ -1206,7 +1206,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        topic: request.topic || '',
+        topic: request.topic ?? '',
       });
     this.initialize();
     return this.innerApiCalls.listTopicSubscriptions(
@@ -1251,7 +1251,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        topic: request.topic || '',
+        topic: request.topic ?? '',
       });
     const defaultCallSettings = this._defaults['listTopicSubscriptions'];
     const callSettings = defaultCallSettings.merge(options);
@@ -1299,7 +1299,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        topic: request.topic || '',
+        topic: request.topic ?? '',
       });
     const defaultCallSettings = this._defaults['listTopicSubscriptions'];
     const callSettings = defaultCallSettings.merge(options);
@@ -1404,7 +1404,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        topic: request.topic || '',
+        topic: request.topic ?? '',
       });
     this.initialize();
     return this.innerApiCalls.listTopicSnapshots(request, options, callback);
@@ -1445,7 +1445,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        topic: request.topic || '',
+        topic: request.topic ?? '',
       });
     const defaultCallSettings = this._defaults['listTopicSnapshots'];
     const callSettings = defaultCallSettings.merge(options);
@@ -1493,7 +1493,7 @@ export class PublisherClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        topic: request.topic || '',
+        topic: request.topic ?? '',
       });
     const defaultCallSettings = this._defaults['listTopicSnapshots'];
     const callSettings = defaultCallSettings.merge(options);

diff --git a/src/v1/schema_service_client.ts b/src/v1/schema_service_client.ts
@@ -438,7 +438,7 @@ export class SchemaServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     this.initialize();
     return this.innerApiCalls.createSchema(request, options, callback);
@@ -524,7 +524,7 @@ export class SchemaServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        name: request.name || '',
+        name: request.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.getSchema(request, options, callback);
@@ -606,7 +606,7 @@ export class SchemaServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        name: request.name || '',
+        name: request.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.deleteSchema(request, options, callback);
@@ -690,7 +690,7 @@ export class SchemaServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     this.initialize();
     return this.innerApiCalls.validateSchema(request, options, callback);
@@ -782,7 +782,7 @@ export class SchemaServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     this.initialize();
     return this.innerApiCalls.validateMessage(request, options, callback);
@@ -880,7 +880,7 @@ export class SchemaServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     this.initialize();
     return this.innerApiCalls.listSchemas(request, options, callback);
@@ -925,7 +925,7 @@ export class SchemaServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     const defaultCallSettings = this._defaults['listSchemas'];
     const callSettings = defaultCallSettings.merge(options);
@@ -977,7 +977,7 @@ export class SchemaServiceClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        parent: request.parent || '',
+        parent: request.parent ?? '',
       });
     const defaultCallSettings = this._defaults['listSchemas'];
     const callSettings = defaultCallSettings.merge(options);

diff --git a/src/v1/subscriber_client.ts b/src/v1/subscriber_client.ts
@@ -596,7 +596,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        name: request.name || '',
+        name: request.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.createSubscription(request, options, callback);
@@ -678,7 +678,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        subscription: request.subscription || '',
+        subscription: request.subscription ?? '',
       });
     this.initialize();
     return this.innerApiCalls.getSubscription(request, options, callback);
@@ -763,7 +763,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        'subscription.name': request.subscription!.name || '',
+        'subscription.name': request.subscription!.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.updateSubscription(request, options, callback);
@@ -849,7 +849,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        subscription: request.subscription || '',
+        subscription: request.subscription ?? '',
       });
     this.initialize();
     return this.innerApiCalls.deleteSubscription(request, options, callback);
@@ -946,7 +946,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        subscription: request.subscription || '',
+        subscription: request.subscription ?? '',
       });
     this.initialize();
     return this.innerApiCalls.modifyAckDeadline(request, options, callback);
@@ -1038,7 +1038,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        subscription: request.subscription || '',
+        subscription: request.subscription ?? '',
       });
     this.initialize();
     return this.innerApiCalls.acknowledge(request, options, callback);
@@ -1134,7 +1134,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        subscription: request.subscription || '',
+        subscription: request.subscription ?? '',
       });
     this.initialize();
     return this.innerApiCalls.pull(request, options, callback);
@@ -1228,7 +1228,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        subscription: request.subscription || '',
+        subscription: request.subscription ?? '',
       });
     this.initialize();
     return this.innerApiCalls.modifyPushConfig(request, options, callback);
@@ -1314,7 +1314,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        snapshot: request.snapshot || '',
+        snapshot: request.snapshot ?? '',
       });
     this.initialize();
     return this.innerApiCalls.getSnapshot(request, options, callback);
@@ -1428,7 +1428,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        name: request.name || '',
+        name: request.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.createSnapshot(request, options, callback);
@@ -1517,7 +1517,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        'snapshot.name': request.snapshot!.name || '',
+        'snapshot.name': request.snapshot!.name ?? '',
       });
     this.initialize();
     return this.innerApiCalls.updateSnapshot(request, options, callback);
@@ -1607,7 +1607,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        snapshot: request.snapshot || '',
+        snapshot: request.snapshot ?? '',
       });
     this.initialize();
     return this.innerApiCalls.deleteSnapshot(request, options, callback);
@@ -1710,7 +1710,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        subscription: request.subscription || '',
+        subscription: request.subscription ?? '',
       });
     this.initialize();
     return this.innerApiCalls.seek(request, options, callback);
@@ -1828,7 +1828,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project: request.project || '',
+        project: request.project ?? '',
       });
     this.initialize();
     return this.innerApiCalls.listSubscriptions(request, options, callback);
@@ -1869,7 +1869,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project: request.project || '',
+        project: request.project ?? '',
       });
     const defaultCallSettings = this._defaults['listSubscriptions'];
     const callSettings = defaultCallSettings.merge(options);
@@ -1917,7 +1917,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project: request.project || '',
+        project: request.project ?? '',
       });
     const defaultCallSettings = this._defaults['listSubscriptions'];
     const callSettings = defaultCallSettings.merge(options);
@@ -2020,7 +2020,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project: request.project || '',
+        project: request.project ?? '',
       });
     this.initialize();
     return this.innerApiCalls.listSnapshots(request, options, callback);
@@ -2061,7 +2061,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project: request.project || '',
+        project: request.project ?? '',
       });
     const defaultCallSettings = this._defaults['listSnapshots'];
     const callSettings = defaultCallSettings.merge(options);
@@ -2109,7 +2109,7 @@ export class SubscriberClient {
     options.otherArgs.headers = options.otherArgs.headers || {};
     options.otherArgs.headers['x-goog-request-params'] =
       this._gaxModule.routingHeader.fromParams({
-        project: request.project || '',
+        project: request.project ?? '',
       });
     const defaultCallSettings = this._defaults['listSnapshots'];
     const callSettings = defaultCallSettings.merge(options);