feat: add support for OTel context propagation and harmonized spans #1833

feywind · 2023-09-20T21:02:33Z

This PR adds support for OTel context propagation using the standard W3C headers as Pub/Sub attributes. It also harmonizes the spans we're using with the planned spans in other language libraries.

Fixes #1389

(This is the 4.x version of #1659 - I'll still be backporting to there, but the changes will go here first.)

…erly

…make one

…e of telemetry tracing

… wasn't ready

…l-4-sampler

feat: provide bidi links between RPC and message spans, and filter by isSampled; upgrade otel deps

…l-4-function

fix: update ack/modack spans to match latest spec

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

samples: add the otel enable flag to new otel samples

generated-files-bot · 2024-08-07T21:56:45Z

Warning: This pull request is touching the following templated files:

README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml
samples/README.md - samples/README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

feywind · 2024-08-08T17:02:51Z

The otel-beta tag has been updated to 4.5.0-otel-beta.2, which is current as of today. This is pretty close now!

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

feywind and others added 30 commits December 12, 2022 16:28

feat: use the propagation inject framework for OpenTelemetry publishes

0d9c0b2

feat: add propagation extraction to subscriber for OpenTelemetry

4f3daa9

feat: work in progress on adding sub-spans

80d8b65

add more spans

cbd5992

wrap subscriber on() handlers to get better receive process spans

75acbab

update otel core version for tests

bb6cf85

fix: change some span names for doc updates

5cddaed

fix: move emitter wrapper out one level, to catch user functions prop…

d523b1f

…erly

chore: merge remote-tracking branch 'remotes/origin/main' into otel-2

fbe29a2

fix: don't send anything besides what's actually needed during publish

197a214

fix: close the publish span at RPC time, not up front

a36cfce

fix: delay caching of the trace provider so the user has a chance to …

5c4fef6

…make one

build: bring OTel versions back to compatible with Node 12

b58557d

fix: clean up a few more namespace pollution issues in OTel support

4b7cf0c

tests: manually end the publish span for tests

45047c7

build: update package names for recent version updates

3995fd0

chore: get versions of OTel that work together and with Node 12

f2f8f57

chore: linter nit

4a2a79e

chore: another linter nit

bb815d3

chore: OTel sample formatting

5d60ff3

chore: some internal renaming to reflect the function rather than nam…

f8a5c09

…e of telemetry tracing

fix: more work towards the Promise-first publish flow

d21480d

tests: remove unnecessary init line

fe4947d

fix: add tracing support for updating the topic name in publisher spans

568add9

fix: use the most up to date name for topic, subscription, and iam

5243ea9

fix: update telemetry spans before publishing, in case the topic name…

8dd13f8

… wasn't ready

chore: merge remote-tracking branch 'remotes/origin/main' into otel-2

60c70a8

chore: merge remote-tracking branch 'remotes/origin/main' into otel-2

57c1673

chore: merge remote-tracking branch 'remotes/origin/main' into otel-2

0a3b9a6

chore: calm linter qualms

bc95037

feywind added 9 commits July 26, 2024 14:52

docs: update comment based on CR

9c04f8b

chore: merge remote-tracking branch 'remotes/feywind/otel-4' into ote…

175526e

…l-4-sampler

tests: publishSpan might be undefined if tracing isn't enabled

b66fa7e

Merge pull request #9 from feywind/otel-4-sampler

2f2585b

feat: provide bidi links between RPC and message spans, and filter by isSampled; upgrade otel deps

chore: merge remote-tracking branch 'remotes/feywind/otel-4' into ote…

6c5c97e

…l-4-function

chore: small merge issue

b3e7524

feat: track code.function

9292e2f

fix: update spans for ack/modack to match newest spec

d436f2c

fix: update ack/modack spans to match latest spec (draft)

8974fb0

fix: update ack/modack spans to match latest spec

feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 30, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 30, 2024

gcf-owl-bot bot and others added 3 commits July 30, 2024 20:00

🦉 Updates from OwlBot post-processor

3a4cf90

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

samples: add the otel enable flag to new otel samples

0513cd2

Merge pull request #12 from feywind/otel-4-samples-enable

f195bf5

samples: add the otel enable flag to new otel samples

feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 7, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 7, 2024

🦉 Updates from OwlBot post-processor

3ea2fc4

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'main' into otel-4

c0db4e7

feywind added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 23, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2024

gcf-owl-bot bot and others added 2 commits August 23, 2024 20:37

🦉 Updates from OwlBot post-processor

83b6e41

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

docs: last minute review, mostly adding private/internal doc tags

4283276

feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 23, 2024

hongalex approved these changes Aug 24, 2024

View reviewed changes

feywind merged commit 4b5c90d into googleapis:main Aug 24, 2024
15 checks passed

release-please bot mentioned this pull request Aug 24, 2024

chore(main): release 4.7.0 #1960

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for OTel context propagation and harmonized spans #1833

feat: add support for OTel context propagation and harmonized spans #1833

feywind commented Sep 20, 2023

generated-files-bot bot commented Aug 7, 2024

feywind commented Aug 8, 2024

feat: add support for OTel context propagation and harmonized spans #1833

feat: add support for OTel context propagation and harmonized spans #1833

Conversation

feywind commented Sep 20, 2023

generated-files-bot bot commented Aug 7, 2024

feywind commented Aug 8, 2024