Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update linter to remove errors #1906

Merged
merged 8 commits into from
Aug 21, 2023
Merged

chore: update linter to remove errors #1906

merged 8 commits into from
Aug 21, 2023

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Aug 17, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: u Pull request is empty. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Aug 17, 2023
@sofisl sofisl requested review from a team as code owners August 17, 2023 20:12
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: u Pull request is empty. labels Aug 17, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 17, 2023
@sofisl sofisl changed the title test repo health fix: linting errors Aug 18, 2023
@sofisl
Copy link
Contributor Author

sofisl commented Aug 18, 2023

Linter will be fixed here: google/gts#778

@sofisl sofisl changed the title fix: linting errors chore: update linter to remove errors Aug 21, 2023
@sofisl sofisl merged commit 19e0765 into main Aug 21, 2023
19 checks passed
@sofisl sofisl deleted the testRepoHealth branch August 21, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sofisl @surbhigarg92