Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add support for class MultiplexedSession #2191

Closed
wants to merge 9 commits into from
Closed

chore: add support for class MultiplexedSession #2191

wants to merge 9 commits into from

Conversation

alkatrivedi
Copy link
Contributor

This PR contains the code for the newly introduced class MultiplexedSession.

@alkatrivedi alkatrivedi requested review from a team as code owners November 13, 2024 15:26
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Nov 13, 2024
@alkatrivedi alkatrivedi force-pushed the class-multiplexed-session branch 2 times, most recently from 27cf336 to 51df606 Compare November 18, 2024 08:20
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Nov 18, 2024 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@alkatrivedi alkatrivedi force-pushed the class-multiplexed-session branch from 10899dc to ba378f2 Compare November 18, 2024 10:06
@alkatrivedi alkatrivedi force-pushed the class-multiplexed-session branch from 04b8f76 to f6674b9 Compare November 19, 2024 10:12
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2024
surbhigarg92
surbhigarg92 reviewed Nov 20, 2024
View reviewed changes
@alkatrivedi alkatrivedi force-pushed the class-multiplexed-session branch 9 times, most recently from 25cec8e to 5101675 Compare November 25, 2024 08:58
@alkatrivedi alkatrivedi force-pushed the class-multiplexed-session branch from 5101675 to 99a18ae Compare November 25, 2024 10:27
@alkatrivedi alkatrivedi force-pushed the class-multiplexed-session branch from b978f8c to cda3ed3 Compare November 25, 2024 10:47
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2024
@alkatrivedi alkatrivedi force-pushed the class-multiplexed-session branch from a6f098f to 73dbf40 Compare December 9, 2024 05:23
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@alkatrivedi alkatrivedi force-pushed the class-multiplexed-session branch from 73dbf40 to 2844dcf Compare December 9, 2024 06:09
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 9, 2024
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@surbhigarg92 surbhigarg92 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 9, 2024
@harshachinta harshachinta mentioned this pull request Dec 9, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 9, 2024
@alkatrivedi
chore: add support for class MultiplexedSession (#2201)
92248c1 
This PR contains the code for the newly introduced class `MultiplexedSession`.

This PR includes the same changes as [PR #2191](https://togithub.com/googleapis/nodejs-spanner/pull/2191), which has already been reviewed. The previous PR had to be closed due to restrictions on OwlBot runs, which prevented it from being merged.
@alkatrivedi
Copy link
Contributor Author

Closing this PR, since we are facing issues in presubmit check for Owlbot Processor. I have moved the changes into another branch which has been created from the main repo. Link to the new PR.

@alkatrivedi alkatrivedi closed this Dec 9, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2024
surbhigarg92 pushed a commit that referenced this pull request Dec 10, 2024
@alkatrivedi @surbhigarg92
chore: add support for class MultiplexedSession (#2201)
b5b50fa 
This PR contains the code for the newly introduced class `MultiplexedSession`.

This PR includes the same changes as [PR #2191](https://togithub.com/googleapis/nodejs-spanner/pull/2191), which has already been reviewed. The previous PR had to be closed due to restrictions on OwlBot runs, which prevented it from being merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

@harshachinta harshachinta harshachinta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alkatrivedi @harshachinta @surbhigarg92 @yoshi-kokoro