Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add runTransactionAsync method #294

Merged
merged 2 commits into from
Aug 23, 2018
Merged

add runTransactionAsync method #294

merged 2 commits into from
Aug 23, 2018

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Aug 10, 2018 •
edited
Loading

Offers an alternative model to alleviate some of the issues in #249

@ghost ghost assigned crwilcox Aug 10, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2018
@hans-lizihan
Copy link

hans-lizihan commented Aug 20, 2018 •
edited
Loading

kindly ask how internal retry of transaction.commit() and transaction.rollback() works? what we actually encountered is that upon commit or rollback, it seems like it cannot solve the problem of #216 because it's something related to transaction.commit() and transaction.rollback() retry mechanism

@crwilcox
Copy link
Contributor Author

@JustinBeckwith

JustinBeckwith
JustinBeckwith reviewed Aug 20, 2018
View reviewed changes
src/database.js Outdated
* // ...
* });
*/
Database.prototype.runTransactionAsync = function(runFn) {

This comment was marked as spam.

Sign in to view

@codecov
Copy link

codecov bot commented Aug 21, 2018 •
edited
Loading

Codecov Report

Merging #294 into master will decrease coverage by 0.38%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
- Coverage     100%   99.61%   -0.39%     
==========================================
  Files          12       12              
  Lines        1289     1295       +6     
==========================================
+ Hits         1289     1290       +1     
- Misses          0        5       +5
Impacted Files Coverage Δ
src/database.js 97.79% <16.66%> (-2.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a24f57...939a658. Read the comment docs.

@JustinBeckwith
Copy link
Contributor

@crwilcox sorry about this, need a rebase on this one

JustinBeckwith
JustinBeckwith suggested changes Aug 22, 2018
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something got messed up with the rebase

@crwilcox crwilcox force-pushed the add-async-runtransaction branch 2 times, most recently from 5d19f77 to 6f44f5a Compare August 22, 2018 21:37
@crwilcox crwilcox force-pushed the add-async-runtransaction branch from 2ce53f9 to d34705b Compare August 23, 2018 00:32
@crwilcox crwilcox force-pushed the add-async-runtransaction branch from 939a658 to de83219 Compare August 23, 2018 00:50
@crwilcox crwilcox merged commit d27113c into master Aug 23, 2018
@crwilcox crwilcox mentioned this pull request Aug 24, 2018
Merged
@jmdobry jmdobry deleted the add-async-runtransaction branch October 16, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

Assignees

@crwilcox crwilcox

Labels
cla: yes This human has signed the Contributor License Agreement. reporter: googler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crwilcox @hans-lizihan @JustinBeckwith @googlebot @dpebot