fix(deps): update dependency @google-cloud/common-grpc to ^0.10.0 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
googlebot
added
the
cla: yes
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label |
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@stephenplusplus @callmehiphop could one of y'all take a look at this? It looks like an issue with the |
system-test/spanner.ts
Outdated
| @@ -29,7 +29,7 @@ const {Spanner} = require('../src'); | |||
| const PREFIX = 'gcloud-tests-'; | |||
| const RUN_ID = uuid.v1().split('-').shift(); // get a short uuid | |||
| const LABEL = `gcloud-tests-${RUN_ID}`; | |||
| const spanner = new Spanner({projectId: process.env.GCLOUD_PROJECT}); | |||
| const spanner = new Spanner(); | |||
There was a problem hiding this comment.
These are the failures removing this line causes:
1) Spanner
Instances
should have created the instance:
+ expected - actual
-projects/long-door-651/instances/gcloud-tests-instance-28be8ad0
+projects/{{projectId}}/instances/gcloud-tests-instance-28be8ad0
2) Spanner
Databases
should have created the database:
+ expected - actual
-projects/long-door-651/instances/gcloud-tests-instance-28be8ad0/databases/gcloud-tests-database-28bfc350
+projects/{{projectId}}/instances/gcloud-tests-instance-28be8ad0/databases/gcloud-tests-database-28bfc350
These failures are because the library is correctly replacing the {{projectId}} token with the actual project ID. It just makes it easier to be explicit with the project ID in the constructor to avoid changing the tests to parse out the project ID from the resource ID we create.
JustinBeckwith
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
JustinBeckwith
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^0.9.2->^0.10.0Release Notes
googleapis/nodejs-common-grpc
v0.10.0Compare Source
01-28-2019 13:51 PST
Dependencies
Documentation
Internal / Testing Changes
Renovate configuration
📅 Schedule: "after 9am and before 3pm" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "
rebase!".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.