Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Conversation

@beccasaurus
Copy link
Contributor

@beccasaurus beccasaurus commented Feb 22, 2018

This PR adds samples for Speech API's model selection feature.

Samples are based on Python canonical samples here: python-docs-samples#1361

  • speech_transcribe_model_selection
  • speech_transcribe_model_selection_gcs

Adds test resource samples/resources/Google_Gnome.wav which validates working video model

These samples are for API v1p1beta1. Samples & test are in separate files, following nodejs-vision convention: detect.v1p1beta1.js


TODO

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2018
@ghost ghost assigned beccasaurus Feb 22, 2018
@beccasaurus beccasaurus requested a review from ace-n February 22, 2018 20:03
@beccasaurus
Copy link
Contributor Author

  • repo-tools lint run complains about trailing commas
  • npm run lint complains about missing trailing commas

Which linter are we using for samples? ESLint is angry.

@beccasaurus beccasaurus requested review from lukesneeringer and removed request for ace-n February 22, 2018 23:27
@beccasaurus beccasaurus changed the title [DO NOT MERGE] Add Speech Recognition v1p1beta1 samples Add Speech Recognition v1p1beta1 samples Feb 26, 2018
@beccasaurus
Copy link
Contributor Author

Ready to merge, pending review

@codecov
Copy link

codecov bot commented Feb 26, 2018

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #33   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          29     29           
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a7d791...0ed9e59. Read the comment docs.

@beccasaurus beccasaurus merged commit f5e99bc into master Feb 26, 2018
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2018
@stephenplusplus stephenplusplus deleted the model-selection-samples branch March 21, 2018 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants