fix: change copyoptions type (#2439)

* fix: change copyoptions type * fix: added test * chore: address pr comments
googleapis · Apr 22, 2024 · 2ebd7ac · 2ebd7ac
1 parent 1d434a9
commit 2ebd7ac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/file.ts b/src/file.ts
@@ -361,7 +361,9 @@ export interface CopyOptions {
   contentType?: string;
   contentDisposition?: string;
   destinationKmsKeyName?: string;
-  metadata?: FileMetadata;
+  metadata?: {
+    [key: string]: string | boolean | number | null;
+  };
   predefinedAcl?: string;
   token?: string;
   userProject?: string;

diff --git a/test/file.ts b/test/file.ts
@@ -545,12 +545,17 @@ describe('File', () => {
 
     it('should accept an options object', done => {
       const newFile = new File(BUCKET, 'name');
+      const METADATA = {
+        metadataKey: 'metadataValue',
+      };
       const options = {
         option: true,
+        metadata: METADATA,
       };
 
       file.request = (reqOpts: DecorateRequestOptions) => {
         assert.deepStrictEqual(reqOpts.json, options);
+        assert.strictEqual(reqOpts.json.metadata, METADATA);
         done();
       };