Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TransferManager#downloadFileInChunks issues #2373

Merged
merged 7 commits into from
Nov 29, 2023
Merged

fix: TransferManager#downloadFileInChunks issues #2373

merged 7 commits into from
Nov 29, 2023

Commits on Nov 28, 2023

  1. First pass at fixes for googleapis#2372

    @rhodgkins
    rhodgkins committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1e613e6 View commit details
    Browse the repository at this point in the history

  2. Added JSDoc for DownloadFileInChunksOptions#noReturnData

    @rhodgkins
    rhodgkins committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    b9fc725 View commit details
    Browse the repository at this point in the history

  3. Changed type of DownloadFileInChunksOptions#noReturnData to be cleare… 

    …r on the default
    @rhodgkins
    rhodgkins committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    87f5f49 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Update src/transfer-manager.ts 

    Fixed typo

Co-authored-by: Daniel Bankhead <dan@danielbankhead.com>
    @rhodgkins @danielbankhead
    rhodgkins and danielbankhead authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    2310d72 View commit details
    Browse the repository at this point in the history

  2. TransferManager#downloadFileInChunks test case for failed CRC32C vali… 

    …dation
    @rhodgkins
    rhodgkins committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    5045acf View commit details
    Browse the repository at this point in the history

  3. TransferManager#downloadFileInChunks test case for return values and … 

    …noReturnData option
    @rhodgkins
    rhodgkins committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    6bcd503 View commit details
    Browse the repository at this point in the history

  4. Fixed JSDocs for TransferManager#downloadFileInChunks

    @rhodgkins
    rhodgkins committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    fba246c View commit details
    Browse the repository at this point in the history