Skip to content

Conversation

@thiyaguk09
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Description

This pull request addresses a timeout issue in the Common Service test suite. The test, which validates the request retry mechanism, was intermittently failing in the CI environment due to a 60-second timeout. This was likely caused by a combination of network latency and the exponential backoff strategy used for retries, where the cumulative delay exceeded the default timeout.

This change increases the test timeout from 60 seconds to 90 seconds to prevent these intermittent failures, ensuring the test can complete its full retry cycle.

Impact

This change resolves the flakiness of the should retry a request system test. By ensuring the test runs reliably, it improves the stability of our CI/CD pipeline and prevents unnecessary test failures that are not related to a bug in the code. The change has no impact on production code; it only affects the test suite.

Testing

  • Unit and integration tests were not added, as this change is a refactor of an existing system test.

  • The should retry a request system test was changed to correct the race condition.

  • No breaking changes are necessary. The change is isolated to the test environment.

Additional Information

The intermittent timeout suggests that the retry backoff logic can, at times, result in a total wait time close to or slightly exceeding the previous 60-second timeout limit. Increasing the timeout provides a more robust window for the test to pass without a false negative. The change also includes a code comment to explain the reasoning behind the increased timeout, improving future maintenance and clarity.

Checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease
  • Appropriate docs were updated
  • Appropriate comments were added, particularly in complex areas or places that require background
  • No new warnings or issues will be generated from this change

Fixes #2647

@thiyaguk09 thiyaguk09 requested review from a team as code owners September 18, 2025 06:57
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Sep 18, 2025
@ddelgrosso1 ddelgrosso1 merged commit b38b5d2 into main Sep 18, 2025
19 checks passed
@ddelgrosso1 ddelgrosso1 deleted the fix/common-service-request-retry branch September 18, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Common Service: should retry a request failed

3 participants