Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate types #3 #391

Merged
merged 15 commits into from
Sep 19, 2018
Merged

Annotate types #3 #391

merged 15 commits into from
Sep 19, 2018

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Sep 14, 2018

No description provided.

@ghost ghost assigned jkwlui Sep 14, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 14, 2018
@ghost ghost assigned JustinBeckwith Sep 14, 2018
JustinBeckwith
JustinBeckwith suggested changes Sep 14, 2018
View reviewed changes
src/bucket.ts Outdated Show resolved Hide resolved
src/bucket.ts Outdated Show resolved Hide resolved
src/bucket.ts Outdated Show resolved Hide resolved
src/bucket.ts Outdated Show resolved Hide resolved
src/bucket.ts Outdated Show resolved Hide resolved
src/bucket.ts Outdated Show resolved Hide resolved
@jkwlui
Copy link
Member Author

jkwlui commented Sep 17, 2018 •
edited
Loading

Fixed the following via the last few commits:

  • Remove overloads in Callbacks
  • Rename options args to optionsOrCallback to match with the actual overloaded type
  • Rename -Request interfaces to -Options to match with name of argument (options)
  • apiResponse typed request.Response instead of object
  • For callback overloads, return void

@JustinBeckwith JustinBeckwith merged commit 49be5b6 into master Sep 19, 2018
@stephenplusplus stephenplusplus deleted the improve-types-3 branch October 1, 2018 14:24
@dependencies dependencies bot mentioned this pull request Oct 12, 2018
Closed
@dfrankes dfrankes mentioned this pull request Aug 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees

@JustinBeckwith JustinBeckwith

@jkwlui jkwlui

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkwlui @JustinBeckwith @googlebot