Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Talent Solution Jobs API v4 samples: Searches for a job with custom ranking search failed #344

Closed
flaky-bot bot opened this issue Jul 10, 2021 · 2 comments · Fixed by #375
Closed

Talent Solution Jobs API v4 samples: Searches for a job with custom ranking search failed #344

flaky-bot bot opened this issue Jul 10, 2021 · 2 comments · Fixed by #375
Assignees
@SurferJeffAtGoogle
Labels
api: jobs Issues related to the googleapis/nodejs-talent API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jul 10, 2021

Note: #329 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: d7553a9
buildURL: Build Status, Sponge
status: failed

Test output
expected '' to match /Job summary/
AssertionError: expected '' to match /Job summary/
    at Context. (test/talent.test.js:128:12)
    at processImmediate (internal/timers.js:461:21)
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jul 10, 2021
@product-auto-label product-auto-label bot added api: jobs Issues related to the googleapis/nodejs-talent API. samples Issues that are directly related to samples. labels Jul 10, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Jul 11, 2021

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (d7553a9), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Jul 11, 2021
@tmatsuo tmatsuo added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jul 16, 2021
@tmatsuo
Copy link

tmatsuo commented Jul 16, 2021

Downgrading because it's happening rarely, but should be fixed.

Looking at the code:

nodejs-talent/samples/snippet/job_search_custom_ranking_search.js

Line 58 in b7c62ac

const resources = responses[0];

Currently the sample is picking the first element. It might be possible that the responses has multiple entries and the first one is empty and non-first entry might have the results. Maybe we can just iterate all the entries in the results.

@SurferJeffAtGoogle SurferJeffAtGoogle self-assigned this Oct 15, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 15, 2021
SurferJeffAtGoogle added a commit that referenced this issue Oct 15, 2021
@SurferJeffAtGoogle
fix: flaky sample test two ways
758b1c5 
1. Examine all the resources in the response.
2. I suspect, but cannot prove that the search function is eventually
   consistent.  So, give it some time.

Fixes #344
@SurferJeffAtGoogle SurferJeffAtGoogle mentioned this issue Oct 15, 2021
Merged
SurferJeffAtGoogle added a commit that referenced this issue Oct 20, 2021
@SurferJeffAtGoogle
fix: flaky sample test two ways (#375)
d722bdb 
1. Examine all the resources in the response.
2. I suspect, but cannot prove that the search function is eventually
   consistent.  So, give it some time.

Fixes #344
NimJay pushed a commit to GoogleCloudPlatform/nodejs-docs-samples that referenced this issue Nov 9, 2022
@SurferJeffAtGoogle
fix: flaky sample test two ways (#375)
bf90504 
1. Examine all the resources in the response.
2. I suspect, but cannot prove that the search function is eventually
   consistent.  So, give it some time.

Fixes googleapis/nodejs-talent#344
telpirion pushed a commit to GoogleCloudPlatform/nodejs-docs-samples that referenced this issue Nov 9, 2022
@SurferJeffAtGoogle
fix: flaky sample test two ways (#375)
759bb24 
1. Examine all the resources in the response.
2. I suspect, but cannot prove that the search function is eventually
   consistent.  So, give it some time.

Fixes googleapis/nodejs-talent#344
telpirion pushed a commit to GoogleCloudPlatform/nodejs-docs-samples that referenced this issue Nov 9, 2022
@SurferJeffAtGoogle @telpirion
fix: flaky sample test two ways (#375)
8a3ef82 
1. Examine all the resources in the response.
2. I suspect, but cannot prove that the search function is eventually
   consistent.  So, give it some time.

Fixes googleapis/nodejs-talent#344
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SurferJeffAtGoogle SurferJeffAtGoogle

Labels
api: jobs Issues related to the googleapis/nodejs-talent API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: flaky sample test two ways googleapis/nodejs-talent
2 participants
@tmatsuo @SurferJeffAtGoogle