Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Move samples to this repository #57

Closed
JustinBeckwith opened this issue May 16, 2019 · 4 comments
Closed

Move samples to this repository #57

JustinBeckwith opened this issue May 16, 2019 · 4 comments
Assignees
Labels
api: jobs Issues related to the googleapis/nodejs-talent API. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.

Comments

@JustinBeckwith
Copy link
Contributor

I was looking around at samples, and noticed these over here:
https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/talent-v4beta1-samples/jobs/v4

We really should have these in the samples/ dir in this repo, so it's consistent with the rest of the node.js repositories.

@JustinBeckwith JustinBeckwith added the type: docs Improvement to the documentation for an API. label May 16, 2019
@beccasaurus
Copy link

Those samples are not to be merged, they're pending a design implementation.

Talent v4beta1 samples will hit all 7 language client library repos in the coming weeks :)

@google-cloud-label-sync google-cloud-label-sync bot added the api: jobs Issues related to the googleapis/nodejs-talent API. label Jan 30, 2020
@czahedi
Copy link

czahedi commented Feb 18, 2020

Justin that link seems dead. I assume this has been resolved unless I simply don't have access?

@JustinBeckwith
Copy link
Contributor Author

Even better. At some point, someone deleted the branch. Now, this tab for nodejs is empty:
https://cloud.google.com/talent-solution/job-search/docs/libraries#client-libraries-usage-nodejs

There are however out of date samples here, that use the apiary based libs :|
https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/master/jobs

@czahedi czahedi removed their assignment Apr 1, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 12, 2020
@fhinkel fhinkel assigned fhinkel and unassigned telpirion Dec 8, 2020
@fhinkel
Copy link
Contributor

fhinkel commented Dec 8, 2020

Even better. At some point, someone deleted the branch. Now, this tab for nodejs is empty:
https://cloud.google.com/talent-solution/job-search/docs/libraries#client-libraries-usage-nodejs

The branch talent-v4beta1-samples/ was merged into master and then deleted, see GoogleCloudPlatform/nodejs-docs-samples#1801.

The Node.js tab in the docs uses sources from this repo. That got fixed in October.

I opened an issue in nodejs-docs-samples to delete the samples after making sure we don't use them in the docs anymore. See GoogleCloudPlatform/nodejs-docs-samples#2103

@fhinkel fhinkel closed this as completed Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: jobs Issues related to the googleapis/nodejs-talent API. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

No branches or pull requests

5 participants