Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Talent samples should live in googleapis/nodejs-talent #2103

Closed
3 tasks
fhinkel opened this issue Dec 8, 2020 · 2 comments · Fixed by #2104
Closed
3 tasks

Talent samples should live in googleapis/nodejs-talent #2103

fhinkel opened this issue Dec 8, 2020 · 2 comments · Fixed by #2104
Assignees
@fhinkel
Labels
samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@fhinkel
Copy link
Contributor

fhinkel commented Dec 8, 2020 •
edited
Loading

  • kokoro job config
  • kokoro build config
  • Owners file

See googleapis/nodejs-talent#57
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 8, 2020
@fhinkel fhinkel added the type: cleanup An internal cleanup or hygiene concern. label Dec 8, 2020
@fhinkel fhinkel mentioned this issue Dec 8, 2020
Closed
@fhinkel fhinkel self-assigned this Dec 8, 2020
@fhinkel
Copy link
Contributor Author

fhinkel commented Dec 8, 2020

Just kidding, we don't have test configs for those samples. Nothing to delete for Kokoro.

@fhinkel
Copy link
Contributor Author

fhinkel commented Dec 8, 2020

cc @happyhuman

fhinkel added a commit that referenced this issue Dec 8, 2020
@fhinkel
chore: delete samples for talent API
5fa173d 
Samples have moved to
https://github.com/googleapis/nodejs-talent/tree/master/samples/snippet

Fixes: #1803
Fixes: #2103
@fhinkel fhinkel mentioned this issue Dec 8, 2020
Merged
fhinkel added a commit that referenced this issue Dec 10, 2020
@fhinkel @JustinBeckwith
chore: delete samples for talent API (#2104)
3399c95 
Samples have moved to
https://github.com/googleapis/nodejs-talent/tree/master/samples/snippet

Fixes: #1803
Fixes: #2103

Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhinkel fhinkel

Labels
samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: delete samples for talent API GoogleCloudPlatform/nodejs-docs-samples
1 participant
@fhinkel