Beta2ga pdf ocr #104
Beta2ga pdf ocr #104
Conversation
ghost
assigned 
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 78 78
=====================================
Hits 78 78Continue to review full report at Codecov.
|
|
Hi @alexander-fenster @jmdobry , @ace-n , @JustinBeckwith Can you please review this PR? Please note that in order to pass the CircleCi tests, I had to change config.yml a little (with some help from Chris Frater). |
.circleci/config.yml
Outdated
| @@ -3,24 +3,32 @@ workflows: | |||
| version: 2 | |||
| tests: | |||
| jobs: &workflow_jobs | |||
| - node6: | |||
| - node4: | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
samples/detect.js
Outdated
| .then(results => { | ||
| const operation = results[0]; | ||
| // Get a Promise representation of the final result of the job | ||
| operation |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@JustinBeckwith thanks for your comments. I updated the code per your suggestions. |
There was a problem hiding this comment.
Thanks for the changes! LGTM w/ nits, but please make sure @Beccca gives it a one over.
samples/detect.js
Outdated
| filesResponse[0].responses[0].outputConfig.gcsDestination.uri; | ||
| console.log('Json saved to: ' + destinationUri); | ||
| }) | ||
| .catch(function(error) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
… into beta2ga-pdf-ocr
Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)