This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
v1p3beta1: new feature enum manual methods #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ghost
assigned 
jkwlui
force-pushed
the
helper-additional-feature
branch
from
5b9a427 to
d620881
Compare
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 79 83 +4
=====================================
+ Hits 79 83 +4
Continue to review full report at Codecov.
|
jkwlui
requested review from
lukesneeringer,
JustinBeckwith and
alexander-fenster
|
@JustinBeckwith this one is pretty urgent. Could you TAL first thing tomorrow? |
JustinBeckwith
approved these changes
Jul 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are manually written methods.
Fixes #126
Checks features enum (loaded from protos) to see if the desired feature exists. If it does, augment the library with the feature method.