This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Adding no-cover pragma to test_file for Py3 compat imports. #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielmanistaatgoogle
changed the title
|
Change content looks good but please "pragam" -> "pragma" and "test-file" -> "test_file" in your commit log message. |
|
Oy! My bad. |
The import always succeeds in Python 2.7, which is the only version where coverage reports are generated.
dhermes
force-pushed
the
py3-no-cover-test-file
branch
from
5a6f5fc to
9ed0701
Compare
|
Done. |
nathanielmanistaatgoogle
added a commit
that referenced
this pull request
Sep 22, 2015
Add no-cover pragma to test_file for Py3 compat imports.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import always succeeds in Python 2.7, which is the only version where coverage reports are generated.
PS @nathanielmanistaatgoogle I misspoke before. NOW the only line coverage missing in tests are
self.fail()lines.