-
Notifications
You must be signed in to change notification settings - Fork 430
Conversation
(Don't merge until I verify that Travis still works) |
@@ -1,15 +1,7 @@ | |||
language: python | |||
python: 2.7 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I thought we were committed through 1 September. What am I missing? @thobrla, has something changed? |
No change on the gsutil side, still planning on removing Py 2.6. support from gsutil releases made after Sept 1. |
@nathanielmanistaatgoogle I don't anticipate us releasing 4.0.0 until september 1st, and going ahead and getting 2.6 out of the way will allow us to continue our hygiene cleanups unencumbered by 2.6 gcloud-python also dropped 2.6 support today. We're not alone. |
Travis flailing concluded. Everything is green and okay to merge. |
Should we take care of |
@pferate another PR, I just wanted to focus on removing the build system support and updated |
If we integrate this pull request now, doesn't that put us in an unreleasable state until 1 September? Or would we say something like "oh, use 3.x if you want 2.6 support"? |
Only if we really want to hold steadfast to that date. We have essentially 3 downstream dependencies to worry about:
|
So if we adopt this now, gsutil would have to pin their dependency on us to 3.0.0-or-lower through the end of this month? I recognize that the likelihood of problems is very small; I just want to make sure that the correct bounding box has been drawn around them. |
@thobrla can confirm, but I think they're currently bundling < 3.0.0 (maybe even less than 2.0.0). |
Correct - we would need to continue to pin to 3.0.0 or lower. We're already pinned to 2.2.0 because we have porting and integration testing work needed to adopt @jonparrott 's replacement for multistore_file. |
... so @thobrla, it sounds like your explicit consent is needed for this merge? For you to say something like "gsutil will not move its |
Sorry - let me be clear. gsutil is fine with this merge; we won't move past 3.0.0 before 1 September. The caveat is if we find a critical bug in the 2.x branch, we'll need to fix it there and release. |
Squash and merge! |
- python: 2.7 | ||
env: TOX_ENV=system-tests | ||
- python: 3.4 | ||
env: TOX_ENV=system-tests3 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@pferate @jonparrott |
We can easily use |
Isn't the move to |
I had a huge PR (#547) that did the full migration, but it was requested to break it up to make it easier to review. |
Gotcha. Brain dump PRs are difficult to review, I can sympathize. e.g. I'll take a stab at it right now. |
Resolves #298.