-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide ignore_unknown_fields=True
option in from_json
and from_dict
#153
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Comments
software-dov
added
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
labels
Oct 19, 2020
N.B.: It turns out ignoring unknown enums is already possible iff the unknown enum variant is passed as an integer. |
That's good, but unfortunately the API send enums as strings. |
I wouldn't make that a blocker, though since it's an issue in the underlying protobuf library too |
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Oct 19, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [1.11.0](https://www.github.com/googleapis/proto-plus-python/compare/v1.10.2...v1.11.0) (2020-10-19) ### Features * provide a to_dict method ([#154](https://www.github.com/googleapis/proto-plus-python/issues/154)) ([ccf903e](https://www.github.com/googleapis/proto-plus-python/commit/ccf903e3cddfcb1ff539e853594b4342914b7d61)), closes [#153](https://www.github.com/googleapis/proto-plus-python/issues/153) [#151](https://www.github.com/googleapis/proto-plus-python/issues/151) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
This blocking PR googleapis/python-bigquery#332 (and as a result the
type
totype_
change googleapis/python-bigquery#316 and googleapis/python-bigquery#328 with the new protobuf changes from the last year of updates from the BQML API -- though I might hack that one to ignore thetype
totype_
change)I'd quite like to actually use proto-plus in
google-cloud-bigquery
( googleapis/python-bigquery#332 ) rather than the current_pb
workaround, but I can't without this change.BigQuery very often launches new model types and model stats properties and updates the protos only after customers have used it in their projects. We need to be able to ignore unknown fields (and ideally unknown enums too, but that doesn't appear to be supported yet in the Python protobuf package protocolbuffers/protobuf#7392)
The text was updated successfully, but these errors were encountered: