Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob #970

Merged
merged 8 commits into from
Feb 15, 2022

Conversation

ivanmkc
Copy link
Contributor

@ivanmkc ivanmkc commented Jan 24, 2022

Added scheduling to CustomTrainingJob and CustomContainerTrainingJob according to established API from CustomJob.

  • CustomTrainingJob
  • CustomPythonPackageTrainingJob
  • CustomContainerTrainingJob
  • Unit tests
  • Integration test

@ivanmkc ivanmkc changed the title Added scheduling to CustomTrainingJob and CustomContainerTrainingJob WIP: Added scheduling to CustomTrainingJob and CustomContainerTrainingJob Jan 24, 2022
@ivanmkc ivanmkc changed the title WIP: Added scheduling to CustomTrainingJob and CustomContainerTrainingJob feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob Jan 25, 2022
@ivanmkc ivanmkc force-pushed the imkc--customtrainingjob-scheduling branch 2 times, most recently from 01b7409 to 6fefbca Compare January 25, 2022 21:39
@ivanmkc ivanmkc changed the title feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob [WIP] feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob Jan 25, 2022
@ivanmkc ivanmkc changed the title [WIP] feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob Jan 28, 2022
@ivanmkc ivanmkc requested a review from a team as a code owner January 28, 2022 23:45
@ivanmkc ivanmkc force-pushed the imkc--customtrainingjob-scheduling branch 3 times, most recently from 804eb06 to 9bfd48b Compare January 31, 2022 22:13
@ivanmkc ivanmkc requested a review from morgandu February 2, 2022 19:40
tests/unit/aiplatform/test_training_jobs.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_training_jobs.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_training_jobs.py Show resolved Hide resolved
@ivanmkc ivanmkc force-pushed the imkc--customtrainingjob-scheduling branch from 82dd428 to fe24ac1 Compare February 14, 2022 17:13
@ivanmkc ivanmkc force-pushed the imkc--customtrainingjob-scheduling branch from fe24ac1 to 7b9db49 Compare February 14, 2022 19:05
@morgandu
Copy link
Contributor

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants