-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob #970
Merged
ivanmkc
merged 8 commits into
googleapis:main
from
ivanmkc:imkc--customtrainingjob-scheduling
Feb 15, 2022
Merged
feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob #970
ivanmkc
merged 8 commits into
googleapis:main
from
ivanmkc:imkc--customtrainingjob-scheduling
Feb 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanmkc
changed the title
Added scheduling to CustomTrainingJob and CustomContainerTrainingJob
WIP: Added scheduling to CustomTrainingJob and CustomContainerTrainingJob
Jan 24, 2022
ivanmkc
changed the title
WIP: Added scheduling to CustomTrainingJob and CustomContainerTrainingJob
feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob
Jan 25, 2022
ivanmkc
force-pushed
the
imkc--customtrainingjob-scheduling
branch
2 times, most recently
from
January 25, 2022 21:39
01b7409
to
6fefbca
Compare
ivanmkc
changed the title
feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob
[WIP] feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob
Jan 25, 2022
ivanmkc
changed the title
[WIP] feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob
feat: Added scheduling to CustomTrainingJob, CustomPythonPackageTrainingJob, CustomContainerTrainingJob
Jan 28, 2022
ivanmkc
force-pushed
the
imkc--customtrainingjob-scheduling
branch
3 times, most recently
from
January 31, 2022 22:13
804eb06
to
9bfd48b
Compare
morgandu
suggested changes
Feb 7, 2022
ivanmkc
force-pushed
the
imkc--customtrainingjob-scheduling
branch
from
February 14, 2022 17:13
82dd428
to
fe24ac1
Compare
Fixed tests Fixed test fix: Broken test
ivanmkc
force-pushed
the
imkc--customtrainingjob-scheduling
branch
from
February 14, 2022 19:05
fe24ac1
to
7b9db49
Compare
morgandu
approved these changes
Feb 15, 2022
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added scheduling to CustomTrainingJob and CustomContainerTrainingJob according to established API from CustomJob.