Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed getting project ID when running on Vertex AI; Fixes #852 #943

Merged
merged 13 commits into from
Mar 21, 2022
Merged

fix: Fixed getting project ID when running on Vertex AI; Fixes #852 #943

merged 13 commits into from
Mar 21, 2022

Commits on Jan 6, 2022

  1. fix: Fixed getitng project ID when running on Vertex AI 

    When project ID is not explicitly specified in `aiplatform.init()` call, the SDK uses `google.auth.default()` to infer the project ID.
However when running under Vertex AI (CustomJob, PipelineJob), the project returned by `google.auth.default()` is not the correct user project.
See googleapis#852
See googleapis/google-auth-library-python#924
This PR fixes the fallback to get the project ID from the `CLOUD_ML_PROJECT_ID` environment variable.
    @Ark-kun
    Ark-kun committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    1e1cbfe View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Stopped depending on the google-api-python-client package

    @Ark-kun
    Ark-kun committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    5b63ac3 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2022

  1. Fixed a lint warning

    @Ark-kun
    Ark-kun committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    6fe3f2a View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Merge branch 'main' into fix--Fixed-getitng-project-ID-when-running-o… 

    …n-Vertex-AI
    @kweinmeister
    kweinmeister committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    9b50f62 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Merge branch 'main' into fix--Fixed-getitng-project-ID-when-running-o… 

    …n-Vertex-AI
    @sasha-gitg
    sasha-gitg committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    915d979 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Merge branch 'main' into fix--Fixed-getitng-project-ID-when-running-o… 

    …n-Vertex-AI
    @Ark-kun
    Ark-kun committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    318ad9e View commit details
    Browse the repository at this point in the history

  2. Extracted getting the project ID to another module

    @Ark-kun
    Ark-kun committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    46f6324 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2022

  1. Specified the exception type

    @Ark-kun
    Ark-kun committed Mar 13, 2022
    Configuration menu
    Copy the full SHA
    036362e View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. tests: Added project ID inference test

    @Ark-kun
    Ark-kun committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    1f79bce View commit details
    Browse the repository at this point in the history

  2. Added unit test

    @Ark-kun
    Ark-kun committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    de1bb24 View commit details
    Browse the repository at this point in the history

  3. Update test_initializer.py

    @Ark-kun
    Ark-kun committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    bfe1e98 View commit details
    Browse the repository at this point in the history

  4. Patched os.environ in the unit test

    @Ark-kun
    Ark-kun committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    4f20ae0 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2022

  1. Merge branch 'main' into fix--Fixed-getitng-project-ID-when-running-o… 

    …n-Vertex-AI
    @kweinmeister
    kweinmeister committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    c73fc06 View commit details
    Browse the repository at this point in the history