-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable DirectPath support for gRPC workflows #482
Labels
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Comments
dilipped
changed the title
Use compute_engine_channel_credentials to utilize DirectPath
Enable DirectPath support for gRPC workflows
Feb 3, 2023
+1, this change is also likely needed for the new BigTable library |
atulep
added
the
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
label
Feb 13, 2023
Can you include the link to DirectPath docs ? |
Googlers see go/enable-directpath-grpc-python |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Is your feature request related to a problem? Please describe.
The current behavior for grpc does not utilize DirectPath. DirectPath leads to improved latency for request originating from GCE VMs and
gcloud storage
relies on this feature.Describe the solution you'd like
Two changes are needed:
python-api-core/google/api_core/grpc_helpers.py
Line 267 in b6eb6de
with:
where, compute_engine_channel_credentials_requested will be a
bool
passed to thecreate_channel
call. Alternatively, it can rely on the env variable like it's done for other languagesgoogle-c2p
resolver. This can be similar to how other languages e.g. go handles it https://github.com/googleapis/google-api-go-client/blob/8d8f0a70d0bd6ba4daaa08370d1420f759ff7f9d/transport/grpc/dial.go#L182Describe alternatives you've considered
For
#2
above, we can potentially update the GAPIC client generator to create the host name withgoogle-c2p:///
prefixed. But I think given that all other languages are handling it in the middleware, it is appropriate to make this change in this library.Additional context
There is an internal bug related to this, but I'm not sure if I link it on a public repo.
The text was updated successfully, but these errors were encountered: