Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CBT-6 helper] Exposing Retry._deadline as a property #20

Merged
merged 7 commits into from
May 28, 2020

Conversation

mf2199
Copy link
Contributor

@mf2199 mf2199 commented Mar 31, 2020

The suggested way of fixing cbt-6 involves propagating the value of a private member of the Retry class down to gRPC wrapper. The proposed changes are necessary to avoid the associated linting errors.

Fixes #6

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
@mf2199 mf2199 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 31, 2020
@mf2199 mf2199 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 1, 2020
@mf2199 mf2199 requested a review from kolea2 April 1, 2020 18:29
@kolea2 kolea2 requested a review from crwilcox April 13, 2020 15:04
@mf2199 mf2199 marked this pull request as ready for review April 23, 2020 14:05
@mf2199
Copy link
Contributor Author

mf2199 commented May 27, 2020

@kolea2 Friendly ping.

@kolea2 kolea2 merged commit 7be1e59 into googleapis:master May 28, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigtable: read_rows: no deadline causing stuck clients; no way to change it
5 participants