Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add grpc Compression argument to channels and methods #451

Merged
merged 31 commits into from
Sep 7, 2023
Merged

feat: Add grpc Compression argument to channels and methods #451

merged 31 commits into from
Sep 7, 2023

Conversation

acocuzzo
Copy link
Contributor

The grpc library allows compression to be set the channel as well as call level
Fixes #450 🦕

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 21, 2022
@acocuzzo acocuzzo changed the title (feat): Add grpc Compression argument to channels and methods feat: Add grpc Compression argument to channels and methods Sep 21, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Feb 17, 2023
@acocuzzo acocuzzo marked this pull request as ready for review May 6, 2023 23:48
@acocuzzo acocuzzo requested review from a team as code owners May 6, 2023 23:48
@parthea parthea self-assigned this Sep 1, 2023
parthea
parthea approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one observation. @acocuzzo PTAL

google/api_core/grpc_helpers.py Outdated Show resolved Hide resolved
@parthea parthea assigned acocuzzo and unassigned parthea Sep 1, 2023
parthea
parthea reviewed Sep 2, 2023
View reviewed changes
google/api_core/operations_v1/operations_client.py Outdated Show resolved Hide resolved
google/api_core/operations_v1/operations_client.py Outdated Show resolved Hide resolved
google/api_core/operations_v1/operations_client.py Outdated Show resolved Hide resolved
google/api_core/operations_v1/operations_async_client.py Outdated Show resolved Hide resolved
google/api_core/operations_v1/operations_async_client.py Outdated Show resolved Hide resolved
google/api_core/operations_v1/operations_async_client.py Outdated Show resolved Hide resolved
google/api_core/operations_v1/operations_async_client.py Outdated Show resolved Hide resolved
google/api_core/operations_v1/operations_client.py Outdated Show resolved Hide resolved
acocuzzo and others added 8 commits September 2, 2023 16:27
@acocuzzo @parthea
Update google/api_core/operations_v1/operations_client.py
b1332d8 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo @parthea
Update google/api_core/operations_v1/operations_client.py
c661ecc 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo @parthea
Update google/api_core/operations_v1/operations_client.py
8ffa4da 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo @parthea
Update google/api_core/operations_v1/operations_async_client.py
26438ba 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo @parthea
Update google/api_core/operations_v1/operations_async_client.py
21371b0 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo @parthea
Update google/api_core/operations_v1/operations_async_client.py
8aeeffd 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo @parthea
Update google/api_core/operations_v1/operations_async_client.py
6becbeb 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@acocuzzo @parthea
Update google/api_core/operations_v1/operations_client.py
0aa0249 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@parthea parthea merged commit bdebd63 into googleapis:main Sep 7, 2023
@release-please release-please bot mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@meredithslota meredithslota Awaiting requested review from meredithslota

Assignees

@acocuzzo acocuzzo

Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing grpc.Compression to grpc calls and channels
3 participants
@acocuzzo @parthea @meredithslota