feat: update recognized logging fields #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchudnov-g
reviewed
Dec 5, 2024
google/api_core/client_logging.py
Outdated
Comment on lines
15
to
16
| "httpRequestMethod", | ||
| "httpRequestUrl" "rpcName", |
There was a problem hiding this comment.
As per https://cloud.google.com/logging/docs/structured-logging#structured_logging_special_fields, httpRequest should be of type HttpRequest, which includes the fields requestMethod and requestURL internally.
Suggested change
| "httpRequestMethod", | |
| "httpRequestUrl" "rpcName", | |
| "rpcName", |
ohmayr
force-pushed
the
update-log-fields
branch
from
9871f73 to
88bc82c
Compare
vchudnov-g
reviewed
Dec 6, 2024
| @@ -15,12 +15,13 @@ | |||
| "rpcName", | |||
| "serviceName", | |||
| "credentialsType", | |||
| "credentialInfo", | |||
| "credentialsInfo", | |||
| "universeDomain", | |||
| "request", | |||
| "response", | |||
| "metadata", | |||
There was a problem hiding this comment.
Per the parent design doc, we should still have rpcName, right? (We're using it in the pending PR in the generator)
There was a problem hiding this comment.
Yes we should. I see it here it in the list. Let me know if you see otherwise.
There was a problem hiding this comment.
Oh, my bad. Don't know why I didn't see it before.
vchudnov-g
approved these changes
Dec 6, 2024
| @@ -15,12 +15,13 @@ | |||
| "rpcName", | |||
| "serviceName", | |||
| "credentialsType", | |||
| "credentialInfo", | |||
| "credentialsInfo", | |||
| "universeDomain", | |||
| "request", | |||
| "response", | |||
| "metadata", | |||
There was a problem hiding this comment.
Oh, my bad. Don't know why I didn't see it before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.