Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): update mypy version #768

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(types): update mypy version #768

wants to merge 6 commits into from

Conversation

daniel-sanche
Copy link
Contributor

fix a couple typing issues that were causing recent versions of mypy to fail:

  • exceptions.py: error_info variable was reused for a list, and for an optional dict type. Broke the usages into separate variables
  • grpc_helpers_async: added Generic to _WrappedCall
  • retry_unary: removed _P arguments from target type annotation. We expect target to be a functools.partial, and have no arguments

Fixes #682

@daniel-sanche daniel-sanche requested review from a team as code owners December 16, 2024 19:52
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 16, 2024
@daniel-sanche daniel-sanche marked this pull request as draft December 16, 2024 23:05
@daniel-sanche daniel-sanche marked this pull request as ready for review December 17, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy presubmit fails at HEAD with mypy 1.11+
2 participants