Skip to content

fix(bidi): Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional Callback #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 30, 2025
Merged

fix(bidi): Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional Callback #821

merged 11 commits into from
May 30, 2025

Conversation

@abbrowne126
Copy link
Contributor

@abbrowne126 abbrowne126 commented May 23, 2025 •
edited by parthea
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

BEGIN_COMMIT_OVERRIDE
fix: Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional Callback
END_COMMIT_OVERRIDE

Fixes #820

@abbrowne126 abbrowne126 requested review from a team as code owners May 23, 2025 16:22
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 23, 2025
@abbrowne126 abbrowne126 marked this pull request as draft May 23, 2025 16:24
@abbrowne126 abbrowne126 marked this pull request as ready for review May 23, 2025 16:45
@abbrowne126
Copy link
Contributor Author

abbrowne126 commented May 29, 2025

@parthea , can you please take a look at this pull request?

This was referenced May 29, 2025
Closed
Closed
@abbrowne126 abbrowne126 changed the title fix: add stop() call to BackgroundConsumer failures due to exceptions fix: Allow BackgroundConsumer To Raise Exceptions To Caller With Non-Default Constructor Option May 30, 2025
@abbrowne126 abbrowne126 changed the title fix: Allow BackgroundConsumer To Raise Exceptions To Caller With Non-Default Constructor Option fix: Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Non-Default Constructor Option May 30, 2025
@abbrowne126 abbrowne126 changed the title fix: Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Non-Default Constructor Option fix: Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional Callback May 30, 2025
parthea
parthea previously approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abbrowne126 @parthea
Update tests/unit/test_bidi.py
7fc87c0 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@abbrowne126
Copy link
Contributor Author

abbrowne126 commented May 30, 2025

@parthea updated the WARNING to a NOTE but that caused the approval to expire - could you reapprove?

@abbrowne126 abbrowne126 merged commit 3206c01 into main May 30, 2025
48 checks passed
@abbrowne126 abbrowne126 deleted the fix-background-consumer-error-closures branch May 30, 2025 19:36
@release-please release-please bot mentioned this pull request May 30, 2025
Closed
@parthea parthea added release-please:force-run To run release-please and removed release-please:force-run To run release-please labels May 30, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label May 30, 2025
@parthea parthea added the release-please:force-run To run release-please label May 30, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label May 30, 2025
@parthea parthea changed the title fix: Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional Callback fix(bidi): Allow BackgroundConsumer To Inform Caller of Fatal Exceptions with Optional Callback May 30, 2025
@parthea parthea added the release-please:force-run To run release-please label May 30, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label May 30, 2025
@parthea parthea added the release-please:force-run To run release-please label Jun 2, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

Assignees

@parthea parthea

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bidi BackgroundConsumer not Properly Notifying Caller on Fatal Processing Exceptions

2 participants

@abbrowne126 @parthea