fix: closes tailing streams in bidi classes. #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think we'll need a similar change on the async side as well: https://github.com/chandra-siri/python-api-core/blob/82cea4f767510be2002fcc5807a770b99a2906c1/google/api_core/bidi_async.py#L198 |
product-auto-label
bot
added
size: s
pujawadare
commented
Oct 29, 2025
Contributor
Author
pujawadare
left a comment
pujawadare
left a comment
There was a problem hiding this comment.
Also included async bidi classes in the fix.
daniel-sanche
previously approved these changes
Oct 29, 2025
pujawadare
force-pushed
the
bidi-close
branch
from
712e18a to
a585f25
Compare
product-auto-label
bot
added
size: m
pujawadare
force-pushed
the
bidi-close
branch
2 times, most recently
from
7da01b3 to
6768183
Compare
product-auto-label
bot
added
size: s
pujawadare
force-pushed
the
bidi-close
branch
from
6768183 to
93dff59
Compare
Always put `None` into the request queue when closing a bidi stream. This ensures that the request queue is always signaled as closed, even if the underlying gRPC call object is not yet available.
pujawadare
force-pushed
the
bidi-close
branch
from
3ca7e57 to
695de92
Compare
daniel-sanche
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always put
Noneinto the request queue when closing a bidi stream. This ensures that the request queue is always signaled as closed, even if the underlying gRPC call object is not yet available.Fixes #850 🦕