-
Notifications
You must be signed in to change notification settings - Fork 95
fix: Log version check errors #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Log version check errors #858
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@ReubenFrankel Thanks for this PR. I would like to see the logger type and message modified a bit. Please accept the suggestion and I will approve. If you have a strong objection to the suggestion, I am happy to hear your reasoning. |
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
No objections, I kept the message the same only because that was what was there before and the intention of the PR was to move from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
If the fix for underlying cause is simple (i.e. adjusting the version check), I'm happy to expand this PR to cover that also. |
923af21 to
1314e81
Compare
|
Thank you @ReubenFrankel! |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Partially addresses #857 🦕