Skip to content

fix: fix the default value for na_value for numpy conversions #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 29, 2025
Merged

fix: fix the default value for na_value for numpy conversions #1766

merged 11 commits into from
May 29, 2025

Conversation

sycai
Copy link
Contributor

@sycai sycai commented May 21, 2025 •
edited
Loading

Fix bug b/332588453

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 21, 2025
@sycai sycai marked this pull request as ready for review May 22, 2025 17:46
@sycai sycai requested review from a team as code owners May 22, 2025 17:46
@sycai sycai requested a review from shuoweil May 22, 2025 17:46
@sycai sycai requested a review from chelsea-lin May 22, 2025 17:47
shuoweil
shuoweil previously approved these changes May 22, 2025
View reviewed changes
chelsea-lin
chelsea-lin previously approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please link the internal bug (if we have one) for giving context to reviewers. Thanks!

bigframes/dataframe.py
@@ -4082,7 +4083,7 @@ def to_numpy(
self,
dtype=None,
copy=False,
na_value=None,
na_value=pd_ext.no_default,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the na_value for pandas.to_numpy is set as no_default, this is not counted as breaking change:
https://github.com/pandas-dev/pandas/blob/v2.2.3/pandas/core/frame.py#L1933-L1997

@sycai
Copy link
Contributor Author

sycai commented May 22, 2025

Can we please link the internal bug (if we have one) for giving context to reviewers. Thanks!

My bad: b/332588453

@sycai sycai enabled auto-merge (squash) May 22, 2025 19:01
@sycai sycai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2025
@sycai sycai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2025
@sycai sycai dismissed stale reviews from chelsea-lin and shuoweil via 847ce3a May 29, 2025 00:55
@sycai sycai requested review from chelsea-lin and shuoweil May 29, 2025 02:15
@sycai sycai merged commit 0629cac into main May 29, 2025
24 checks passed
@sycai sycai deleted the sycai_fix branch May 29, 2025 17:54
@release-please release-please bot mentioned this pull request May 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

@shuoweil shuoweil Awaiting requested review from shuoweil

Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sycai @chelsea-lin @shuoweil @tswast @bigframes-bot