fix: fix the default value for na_value for numpy conversions
#1766
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
shuoweil
previously approved these changes
May 22, 2025
chelsea-lin
previously approved these changes
May 22, 2025
| @@ -4082,7 +4083,7 @@ def to_numpy( | |||
| self, | |||
| dtype=None, | |||
| copy=False, | |||
| na_value=None, | |||
| na_value=pd_ext.no_default, | |||
There was a problem hiding this comment.
As the na_value for pandas.to_numpy is set as no_default, this is not counted as breaking change:
https://github.com/pandas-dev/pandas/blob/v2.2.3/pandas/core/frame.py#L1933-L1997
My bad: b/332588453 |
sycai
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
sycai
added
the
kokoro:force-run
bigframes-bot
removed
the
kokoro:force-run
chelsea-lin
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug b/332588453