-
Notifications
You must be signed in to change notification settings - Fork 49
fix: fix the default value for na_value
for numpy conversions
#1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please link the internal bug (if we have one) for giving context to reviewers. Thanks!
@@ -4082,7 +4083,7 @@ def to_numpy( | |||
self, | |||
dtype=None, | |||
copy=False, | |||
na_value=None, | |||
na_value=pd_ext.no_default, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the na_value
for pandas.to_numpy
is set as no_default
, this is not counted as breaking change:
https://github.com/pandas-dev/pandas/blob/v2.2.3/pandas/core/frame.py#L1933-L1997
My bad: b/332588453 |
Fix bug b/332588453