Skip to content

refactor: simplify the plugin detection code, add test coverage #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025

Conversation

shobsi
Copy link
Contributor

@shobsi shobsi commented May 23, 2025

We added instrumentation of the GCP vscode extension and jupyter plugin in pandas-gbq and bigquery-magics. In this change we are propagating the improvements there to BigFrames.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

We added instrumentation of the GCP vscode extension and jupyter plugin in pandas-gbq and bigquery-magics. In this change we are propagating the improvements there to BigFrames.
@shobsi shobsi requested review from a team as code owners May 23, 2025 02:52
@shobsi shobsi requested a review from jialuoo May 23, 2025 02:52
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 23, 2025
@shobsi shobsi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2025
@shobsi shobsi requested a review from Genesis929 May 29, 2025 01:36
@shobsi shobsi merged commit cbb5f14 into main May 29, 2025
24 checks passed
@shobsi shobsi deleted the shobsi-plugin-instrumentation branch May 29, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants