Skip to content

feat: support dict param for dataframe.agg() #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: support dict param for dataframe.agg() #1772

wants to merge 7 commits into from

Conversation

sycai
Copy link
Contributor

@sycai sycai commented May 23, 2025

Fix issue b/419540030

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 23, 2025
@sycai sycai marked this pull request as ready for review May 28, 2025 17:48
@sycai sycai requested review from a team as code owners May 28, 2025 17:48
self,
func: str
| typing.Sequence[str]
| typing.Mapping[blocks.Label, typing.Sequence[str] | str],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] use typing.Union

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine given that we already have from __future import annotations at the top of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants