Skip to content

feat: Support len() on Groupby objects #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2025
Merged

feat: Support len() on Groupby objects #2183

merged 2 commits into from
Oct 22, 2025

Conversation

@TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 20, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review October 20, 2025 23:50
@TrevorBergeron TrevorBergeron requested review from a team as code owners October 20, 2025 23:50
@TrevorBergeron TrevorBergeron requested a review from sycai October 20, 2025 23:50
sycai
sycai reviewed Oct 22, 2025
View reviewed changes
tests/system/small/test_groupby.py
col_names = ["int64_too", "float64_col", "int64_col", "bool_col", "string_col"]
bf_result = len(scalars_df_index[col_names].groupby("bool_col"))
pd_result = len(scalars_pandas_df_index[col_names].groupby("bool_col"))
assert bf_result == pd_result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style nits: empty spaces between "arrange" "act" "assert" blocks: https://g3doc.corp.google.com/eng/doc/devguide/testing/unit/best-practices.md?cl=head&polyglot=python#structure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@TrevorBergeron TrevorBergeron requested a review from sycai October 22, 2025 21:43
@TrevorBergeron TrevorBergeron merged commit 4191821 into main Oct 22, 2025
20 of 25 checks passed
@TrevorBergeron TrevorBergeron deleted the groupby_len branch October 22, 2025 22:28
@release-please release-please bot mentioned this pull request Oct 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sycai sycai sycai approved these changes

Assignees

@shobsi shobsi

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevorBergeron @sycai @shobsi