Skip to content

Conversation

@jialuoo
Copy link
Contributor

@jialuoo jialuoo commented Oct 28, 2025

This commit migrates the round_op operator from the Ibis compiler to the SQLGlot compiler.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/447388852 🦕

This commit migrates the `round_op` operator from the Ibis compiler to the SQLGlot compiler.
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 28, 2025
@jialuoo jialuoo requested a review from chelsea-lin October 29, 2025 17:13
@jialuoo jialuoo marked this pull request as ready for review October 29, 2025 17:13
@jialuoo jialuoo requested review from a team as code owners October 29, 2025 17:13
@jialuoo jialuoo enabled auto-merge (squash) October 29, 2025 17:48
@jialuoo jialuoo added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 29, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 29, 2025
@jialuoo jialuoo merged commit 5ea640f into main Oct 29, 2025
23 of 25 checks passed
@jialuoo jialuoo deleted the feat/migrate-round-op branch October 29, 2025 17:50
shuoweil pushed a commit that referenced this pull request Oct 30, 2025
This commit migrates the `round_op` operator from the Ibis compiler to the SQLGlot compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants