Skip to content

fix: struct field non-nullable type issue. #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix: struct field non-nullable type issue. #914

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35b2d15
fix: struct field non-nullable type issue.
Genesis929 Aug 22, 2024
8048124
update logic
Genesis929 Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bigframes/core/compile/scalar_op_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,9 @@ def struct_field_op_impl(x: ibis_types.Value, op: ops.StructFieldOp):
name = op.name_or_index
else:
name = struct_value.names[op.name_or_index]
return struct_value[name].name(name)

result = struct_value[name]
return result.cast(result.type()(nullable=True)).name(name)


def numeric_to_datetime(x: ibis_types.Value, unit: str) -> ibis_types.TimestampValue:
Expand Down