Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

chore: migrate default branch from master to main #206

Merged
merged 2 commits into from
Aug 27, 2021
Merged

chore: migrate default branch from master to main #206

merged 2 commits into from
Aug 27, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Aug 26, 2021

Closes #205.

@plamut plamut requested review from parthea and a team August 26, 2021 13:12
@plamut plamut requested a review from a team as a code owner August 26, 2021 13:12
@plamut plamut requested a review from shollyman August 26, 2021 13:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2021
@product-auto-label product-auto-label bot added the api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. label Aug 26, 2021
@plamut plamut added owlbot:run Add this label to trigger the Owlbot post processor. and removed api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. cla: yes This human has signed the Contributor License Agreement. labels Aug 26, 2021
@google-cla
Copy link

google-cla bot commented Aug 26, 2021

☹️ Sorry, but only Googlers may change the label cla: yes.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2021
@plamut plamut added the api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. label Aug 26, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2021
@plamut plamut force-pushed the migrate-default-branch-to-main branch from 2e7afc1 to 6b6ba74 Compare August 26, 2021 13:14
plamut
plamut commented Aug 26, 2021
View reviewed changes
setup.py
@@ -35,6 +35,7 @@
"google-api-core[grpc] >= 1.26.0, <3.0.0dev",
"proto-plus >= 1.15.0",
"packaging >= 14.3",
"pytz >= 2021.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not directly related, but it's needed for the samples checks to pass. It seems like an issue similar to other libraries that implicitly depended on pytz and broke when api-core dropped it.

@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2021
@plamut plamut merged commit fee4de9 into googleapis:master Aug 27, 2021
@plamut plamut deleted the migrate-default-branch-to-main branch August 27, 2021 09:03
@plamut
Copy link
Contributor Author

plamut commented Aug 27, 2021

Thanks for the review, now we just need to change the default branch in the repo settings.

@parthea parthea mentioned this pull request Aug 27, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parthea parthea parthea approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquerydatatransfer Issues related to the googleapis/python-bigquery-datatransfer API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate from master to main branch
2 participants
@plamut @parthea