Skip to content

test: add session with prerelease dependencies #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 30, 2021
Merged

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Nov 29, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #426 🦕

@tswast tswast requested a review from a team as a code owner November 29, 2021 21:45
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 29, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Nov 29, 2021
@tswast
Copy link
Collaborator Author

tswast commented Nov 29, 2021

Internal configs added in change 412984922. Once submitted, I can trigger the Kokoro prerelease job. Currently expected to fail. Won't block merges.

Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'll wait until the external CI issue is resolved to see if OwlBot does not override anything.

@tseaver
Copy link
Contributor

tseaver commented Nov 30, 2021

@tswast

Once submitted, I can trigger the Kokoro prerelease job. Currently expected to fail. Won't block merges.

Do we even want to run the prerelease checks during a presubmit? ISTM that they are better caught in nightlies.

@tswast
Copy link
Collaborator Author

tswast commented Nov 30, 2021

Do we even want to run the prerelease checks during a presubmit? ISTM that they are better caught in nightlies.

I agree that nightlies are the most useful (assuming flakeybot actually looks at these jobs. I think it should), though for issues like #426 where we know we want to get ahead of some breaking changes, it's nice to have it as a presubmit.

@tswast tswast requested a review from plamut November 30, 2021 17:01
@plamut plamut added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2021
@plamut
Copy link

plamut commented Nov 30, 2021

Let's see if Owlbot has anything to say now with updated config...

@tswast tswast merged commit 928e47b into main Nov 30, 2021
@tswast tswast deleted the issue426-prerelease-deps branch November 30, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants