-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow extreme DATE values such as datetime.date(1, 1, 1)
in load_gbq
#442
Merged
gcf-merge-on-green
merged 3 commits into
googleapis:main
from
tswast:issue441-load_parquet-DATE
Dec 7, 2021
Merged
fix: allow extreme DATE values such as datetime.date(1, 1, 1)
in load_gbq
#442
gcf-merge-on-green
merged 3 commits into
googleapis:main
from
tswast:issue441-load_parquet-DATE
Dec 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deps: require google-cloud-bigquery 1.26.1 or later
product-auto-label
bot
added
the
api: bigquery
Issues related to the googleapis/python-bigquery-pandas API.
label
Dec 6, 2021
This was referenced Dec 6, 2021
tswast
changed the title
fix: read out-of-bounds DATETIME values such as
fix: allow extreme DATE values such as Dec 6, 2021
0001-01-01 00:00:00
datetime.date(1, 1, 1)
in load_gbq
conda-3.7 issue should be resolved by conda-forge/db-dtypes-feedstock#1 |
tseaver
approved these changes
Dec 7, 2021
@@ -94,8 +94,13 @@ def cast_dataframe_for_parquet( | |||
# .astype() with DateDtype. With .astype(), I get the error: | |||
# | |||
# TypeError: Cannot interpret '<db_dtypes.DateDtype ...>' as a data type | |||
cast_column = pandas.Series( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the comment above be removed now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Good call.
tswast
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Dec 7, 2021
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Dec 7, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 19, 2022
🤖 I have created a release *beep* *boop* --- ## [0.17.0](v0.16.0...v0.17.0) (2022-01-19) ### ⚠ BREAKING CHANGES * use nullable Int64 and boolean dtypes if available (#445) ### Features * accepts a table ID, which downloads the table without a query ([#443](#443)) ([bf0e863](bf0e863)) * use nullable Int64 and boolean dtypes if available ([#445](#445)) ([89078f8](89078f8)) ### Bug Fixes * `read_gbq` supports extreme DATETIME values such as `0001-01-01 00:00:00` ([#444](#444)) ([d120f8f](d120f8f)) * `to_gbq` allows strings for DATE and floats for NUMERIC with `api_method="load_parquet"` ([#423](#423)) ([2180836](2180836)) * allow extreme DATE values such as `datetime.date(1, 1, 1)` in `load_gbq` ([#442](#442)) ([e13abaf](e13abaf)) * avoid iteritems deprecation in pandas prerelease ([#469](#469)) ([7379cdc](7379cdc)) * use data project for destination in `to_gbq` ([#455](#455)) ([891a00c](891a00c)) ### Miscellaneous Chores * release 0.17.0 ([#470](#470)) ([29ac8c3](29ac8c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #441
Towards #365
🦕