refactor: move query and wait logic to separate module #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prepares the way for using the `query_and_wait` method built-in to the client library when available.
product-auto-label
bot
added
size: l
|
Conda test failure appears unrelated and tracked here: #708 |
4 tasks
Linchin
reviewed
Jan 12, 2024
pandas_gbq/exceptions.py
Outdated
| BigQuery configuration. | ||
| """ | ||
|
|
||
| pass |
There was a problem hiding this comment.
nit: should we keep the pass here? Other error classes do not have this.
There was a problem hiding this comment.
You're correct. pass is not needed because there is a docstring. I'll remove.
Linchin
reviewed
Jan 12, 2024
| ): | ||
| """Wait for query to complete, pausing occasionally to update progress. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
I see this method has been moved out to be a helper function, maybe we should also update the description as the parameters have changed.
There was a problem hiding this comment.
Updated docstrings here and added docstrings to the query_and_wait() method.
tswast
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares the way for using the
query_and_waitmethod built-in to the client library when available.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #710
🦕