feat: adds the capability to include custom user agent string #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
the
api: bigquery
|
Follow-up: |
leahecole
approved these changes
Oct 14, 2024
pandas_gbq/gbq.py
Outdated
| @@ -337,11 +341,17 @@ def log_elapsed_seconds(self, prefix="Elapsed", postfix="s.", overlong=6): | |||
|
|
|||
| def get_client(self): | |||
| import google.api_core.client_info | |||
| import pandas | |||
|
|
|||
| # import pandas # noqa: F401 # TODO is this line needed here? | |||
There was a problem hiding this comment.
just adding this comment about addressing the TODO
is the concern that the import is redundant? was it in here for region tag reasons? (I don't see a region tag 🤷🏻♀️ )
chalmerlowe
commented
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to include a custom prefix in the user agent string.
Also includes a feature that allows the hyphen in the legacy user agent string to be replaced by a slash to be more in line with RFC9110.
Current default user agent (product + delimiter + version):
Legacy:
pandas-2.0.1RFC9110:
pandas/2.0.1With a prefix:
Legacy:
<your_custom_string> pandas-2.0.1RFC9110:
<your_custom_string> pandas/2.0.1Fixes #807 🦕