Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set cte_follows_insert to True #1095

Merged
merged 1 commit into from
Jul 18, 2024
+1 −4
Merged

fix: Set cte_follows_insert to True #1095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sqlalchemy_bigquery/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,7 @@ class BigQueryDialect(DefaultDialect):
type_compiler = BigQueryTypeCompiler
ddl_compiler = BigQueryDDLCompiler
execution_ctx_cls = BigQueryExecutionContext
cte_follows_insert = True
supports_alter = False
supports_comments = True
inline_comments = True
Expand Down
4 changes: 0 additions & 4 deletions tests/sqlalchemy_dialect_compliance/test_dialect_compliance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,10 +537,6 @@ def test_round_trip_executemany(self, connection):


class CTETest(_CTETest):
@pytest.mark.skip("Can't use CTEs with insert")
def test_insert_from_select_round_trip(self):
pass

@pytest.mark.skip("Recusive CTEs aren't supported.")
def test_select_recursive_round_trip(self):
pass
Expand Down