Skip to content

Commit

Permalink
feat: add client side lib id with lib version (#760)
Browse files Browse the repository at this point in the history
* .

* .

* .

* .

* .

* .
  • Loading branch information
yirutang authored Mar 19, 2024
1 parent bc806ae commit 05664dc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions google/cloud/bigquery_storage_v1/writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import grpc

from google.cloud.bigquery_storage_v1 import exceptions as bqstorage_exceptions
from google.cloud.bigquery_storage_v1 import gapic_version as package_version
from google.cloud.bigquery_storage_v1 import types as gapic_types
from google.cloud.bigquery_storage_v1.services import big_query_write

Expand Down Expand Up @@ -163,6 +164,10 @@ def _open(
gapic_types.AppendRowsRequest.copy_from(request, self._inital_request_template)
request._pb.MergeFrom(initial_request._pb)
self._stream_name = request.write_stream
if initial_request.trace_id:
request.trace_id = f"python-writer:{package_version.__version__} {initial_request.trace_id}"
else:
request.trace_id = f"python-writer:{package_version.__version__}"

inital_response_future = AppendRowsFuture(self)
self._futures_queue.put(inital_response_future)
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/test_writer_v1.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@

from google.api_core import exceptions
from google.protobuf import descriptor_pb2

import pytest

from google.cloud.bigquery_storage_v1 import exceptions as bqstorage_exceptions
from google.cloud.bigquery_storage_v1 import gapic_version as package_version
from google.cloud.bigquery_storage_v1 import types as gapic_types
from google.cloud.bigquery_storage_v1.services import big_query_write

Expand Down Expand Up @@ -96,6 +98,7 @@ def test_initial_send(background_consumer, bidi_rpc, module_under_test):
),
rows=proto_rows,
),
trace_id=f"python-writer:{package_version.__version__}",
)
bidi_rpc.assert_called_once_with(
start_rpc=mock_client.append_rows,
Expand Down

0 comments on commit 05664dc

Please sign in to comment.