-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Release v2.0.0 #64
Conversation
Three issues causing the samples to fail:
Update: Update 2: I don't yet know what the deal with that namespace import is -
|
Re namespace: The theory you raised in the chat thread seems to be correct. It looks like this is a result of For comparison
(env) busunkim@busunkim:~/github/python-workflows$ python3
Python 3.8.3 (default, Jun 15 2020, 16:29:21)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from google.cloud import bigquery
>>> bigquery
<module 'google.cloud.bigquery' from '/usr/local/google/home/busunkim/github/python-workflows/env/lib/python3.8/site-packages/google/cloud/bigquery/__init__.py'>
>>> from google.cloud.bigquery import connection
>>> bigquery
<module 'google.cloud.bigquery' from '/usr/local/google/home/busunkim/github/python-workflows/env/lib/python3.8/site-packages/google/cloud/bigquery/__init__.py'>
>>> connection
<module 'google.cloud.bigquery.connection' from '/usr/local/google/home/busunkim/github/python-workflows/env/lib/python3.8/site-packages/google/cloud/bigquery/connection/__init__.py'> |
Now I remember, the same question popped up when migrating If we want to use the @tswast came up with the idea of moving BigQuery 2.0 code into |
@plamut Thanks for digging through and reproducing the issue. Ways forward:
Pro (1):
Con (1):
or
Pro (2):
Con (2):
|
Edit I meant that I lean towards (2) -- rename the less-used packages. |
I'd also lean towards changing the namespace of the less used packages. The two problematic packages |
Namespace packages can only contain modules and subpackages, but no content on their own (setuptools docs). Namespace package's If we want I can adjust the import paths in BQ Storage (yet again) to Update: BTW, is |
TL;DR - I managed to get the samples tests pass locally without restructuring the import hacks and without dubious hacks. If somebody can verify these fix(es) locally, we can probably release BQ Storage 2.0 with broken samples and then immediately follow with a BigQuery 2.0 release that will fix them. The steps that had to be made:
I added the changes UPDATE
|
This avoids import errors from google.cloud.bigquery.* namespace.
0ab9700
to
5976d75
Compare
Namespacing: Bazel config will have to be updated,
@busunkim96 (or someone else), can you do that internally? Thanks! Samples: FWIW, the BigQuery adjustments that are needed for the BQ Storage samples to pass can be found in the BigQuery 2.0 preview PR (first commit). |
It's in the "allowed" environment variables: value must match regex I see that it's set here: https://github.com/googleapis/python-bigquery-storage/blob/master/.kokoro/samples/python3.8/presubmit.cfg but from the build failures, I'm not sure that it's actually getting set. |
The logs seem to show bigquery storage being installed from source. (see the last line) nox > Running session py-3.8
nox > Creating virtual environment (virtualenv) using python3.8 in .nox/py-3-8
nox > pip install -r requirements.txt
nox > pip install -r requirements-test.txt
nox > pip install -e /tmpfs/src/github/python-bigquery-storage. |
Merging. The samples test pass locally, but they require the upcoming version of BigQuery, which has not yet been merged and released. |
The release build has started, the log can be viewed here. 🌻 |
🥚 You hatched a release! The release build finished successfully! 💜 |
This pull request was generated using releasetool.