Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add client side lib id with lib version #760

Merged
merged 6 commits into from
Mar 19, 2024
Merged

feat: add client side lib id with lib version #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4c6999a
.
yirutang Mar 19, 2024
9f9e7b4
.
yirutang Mar 19, 2024
bc093c0
.
yirutang Mar 19, 2024
b48fb31
.
yirutang Mar 19, 2024
f120e4f
.
yirutang Mar 19, 2024
4a2f0c6
.
yirutang Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions google/cloud/bigquery_storage_v1/writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import grpc

from google.cloud.bigquery_storage_v1 import exceptions as bqstorage_exceptions
from google.cloud.bigquery_storage_v1 import gapic_version as package_version
from google.cloud.bigquery_storage_v1 import types as gapic_types
from google.cloud.bigquery_storage_v1.services import big_query_write

Expand Down Expand Up @@ -163,6 +164,10 @@ def _open(
gapic_types.AppendRowsRequest.copy_from(request, self._inital_request_template)
request._pb.MergeFrom(initial_request._pb)
self._stream_name = request.write_stream
if initial_request.trace_id:
request.trace_id = f"python-writer:{package_version.__version__} {initial_request.trace_id}"
else:
request.trace_id = f"python-writer:{package_version.__version__}"

inital_response_future = AppendRowsFuture(self)
self._futures_queue.put(inital_response_future)
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/test_writer_v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@

from google.api_core import exceptions
from google.protobuf import descriptor_pb2

import pytest

from google.cloud.bigquery_storage_v1 import exceptions as bqstorage_exceptions
from google.cloud.bigquery_storage_v1 import gapic_version as package_version
from google.cloud.bigquery_storage_v1 import types as gapic_types
from google.cloud.bigquery_storage_v1.services import big_query_write

Expand Down Expand Up @@ -96,6 +98,7 @@ def test_initial_send(background_consumer, bidi_rpc, module_under_test):
),
rows=proto_rows,
),
trace_id=f"python-writer:{package_version.__version__}",
)
bidi_rpc.assert_called_once_with(
start_rpc=mock_client.append_rows,
Expand Down