Skip to content

Commit

Permalink
update todo with thoughts on future perf update
Browse files Browse the repository at this point in the history
  • Loading branch information
tswast committed Oct 7, 2021
1 parent e2e1c7d commit 2e4af92
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion google/cloud/bigquery/_job_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,9 @@ def _to_query_job(
job_complete = query_response.get("jobComplete")
if job_complete:
query_job._properties["status"]["state"] = "DONE"
# TODO: set first page of results if job is "complete"
# TODO: set first page of results if job is "complete" (and there is
# only 1 page of results? otherwise, need some awkward logic
# for DB API and to_dataframe to get destination table)
else:
query_job._properties["status"]["state"] = "PENDING"

Expand Down

0 comments on commit 2e4af92

Please sign in to comment.