Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow/relax upper bound on packaging dependency #1435

Closed
miketheman opened this issue Dec 10, 2022 · 7 comments
Closed

Allow/relax upper bound on packaging dependency #1435

miketheman opened this issue Dec 10, 2022 · 7 comments
Assignees
@tswast
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@miketheman
Copy link

The current requirement on packaging is pinned:

python-bigquery/setup.py

Line 43 in e1aa921

"packaging >= 14.3, <22.0.0dev",

With the release of packaging 22.0, clients using the current release of this project cannot update and benefit from the released version (which removes the last dependency of pyparsing).

The upper boundary was pinned in #1263 - my suggestion would be to remove said upper boundary and release a new version of the library, so that clients have the flexibility to update packages with fewer conflicts.
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 10, 2022
@miketheman miketheman changed the title Allow upper bound on packaging dependency Allow/relax upper bound on packaging dependency Dec 10, 2022
miketheman added a commit to miketheman/warehouse that referenced this issue Dec 10, 2022
@miketheman
chore(deps): pin packaging to upper boundary
18ee102 
`packaging` 22.0 was released recently, removing a dependency on
`pyparsing`, which is cool.

Since `google-cloud-bigquery` pins to pre-22, we cannot update our
dependencies until that is allowed and released, as we will have
conflicts between what is installed in non `main.txt` requirements.

Refs: googleapis/python-bigquery#1435

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman miketheman mentioned this issue Dec 10, 2022
Merged
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 12, 2022
@tswast
Copy link
Contributor

tswast commented Dec 12, 2022

@parthea @chalmerlowe @aribray Thoughts on this one? Seems like the packaging dependency matches our criteria in go/python-client-dependency-management#removing-some-upper-bounds, though perhaps we'd want to make sure we install a prerelease/nightly/git version of the package to catch issues early?

di pushed a commit to pypi/warehouse that referenced this issue Dec 12, 2022
@miketheman
chore(deps): pin packaging to upper boundary (#12664)
48502f9 
`packaging` 22.0 was released recently, removing a dependency on
`pyparsing`, which is cool.

Since `google-cloud-bigquery` pins to pre-22, we cannot update our
dependencies until that is allowed and released, as we will have
conflicts between what is installed in non `main.txt` requirements.

Refs: googleapis/python-bigquery#1435

Signed-off-by: Mike Fiedler <miketheman@gmail.com>

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@parthea
Copy link
Contributor

parthea commented Dec 12, 2022

@tswast Could we drop packaging instead? We're no longer using it in other repositories

@tswast
Copy link
Contributor

tswast commented Dec 12, 2022

No, we cannot. We use it to compare versions of optional dependencies in this package.

@parthea
Copy link
Contributor

parthea commented Dec 13, 2022

If we want to keep the dependency on packaging then I think it's ok to remove the upper bound. I'd recommend trying to remove packaging as a dependency altogether since it's trivial to achieve the same behaviour with our own logic. In other words, we could write code to extract the versions with tests to confirm the behavior. WDYT?

@parthea parthea assigned tswast and unassigned parthea Dec 13, 2022
@miketheman
Copy link
Author

remove the upper bound.

100% agree with this as a "do this now", while the desire for

achieve the same behaviour with our own logic

can be done at one's leisure to remove the dependency altogether.

tswast added a commit that referenced this issue Dec 13, 2022
@tswast
deps: remove upper bound on packaging dependency
cc13e09 
Towards #1435
@tswast tswast mentioned this issue Dec 13, 2022
Merged
4 tasks
tswast added a commit that referenced this issue Jan 13, 2023
@tswast @parthea
deps: remove upper bound on packaging dependency (#1440)
6088129 
* deps: remove upper bound on packaging dependency

Towards #1435

* install prerelease version of packaging

* bump minimum packaging version

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@di
Copy link
Member

di commented Jan 19, 2023 •
edited
Loading

This seems to be resolved by #1440 and the recent 3.4.2 release, should it be closed?

@tswast tswast closed this as completed Jan 23, 2023
@miketheman
Copy link
Author

Thanks for resolving!!

@di di mentioned this issue Feb 1, 2023
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this issue Apr 17, 2023
@tswast @parthea @abdelmegahedgoogle
deps: remove upper bound on packaging dependency (googleapis#1440)
8f92ef7 
* deps: remove upper bound on packaging dependency

Towards googleapis#1435

* install prerelease version of packaging

* bump minimum packaging version

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tswast @di @miketheman @parthea