-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: remove upper bound on packaging dependency #1440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TODO: Need to investigate unit test failure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. I'm also struggling this problem.
I added a small comment.
testing/constraints-3.7.txt
Outdated
@@ -17,6 +17,7 @@ ipython==7.0.1 | |||
opentelemetry-api==1.1.0 | |||
opentelemetry-instrumentation==0.20b0 | |||
opentelemetry-sdk==1.1.0 | |||
packaging==14.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tswast It looks that the problem you suggest comes from this version constraint.
v14.3 of packaging has no major
attribute:
https://github.com/pypa/packaging/blob/14.3/packaging/version.py#L268-L280
I think we need to update the lower bound, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
major
is added since v20.0.
ref: https://github.com/pypa/packaging/releases/tag/20.0
* deps: remove upper bound on packaging dependency Towards googleapis#1435 * install prerelease version of packaging * bump minimum packaging version Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Towards #1435
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #1435
Fixes #1400
🦕